Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add expectations check for PR branch #23226

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[ci] Add expectations check for PR branch #23226

merged 1 commit into from
Dec 19, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 19, 2024 •
edited
Loading

See #23146

@sbc100 sbc100 requested review from kripken and dschuff December 19, 2024 05:08
@sbc100 sbc100 enabled auto-merge (squash) December 19, 2024 07:48
dschuff
dschuff reviewed Dec 19, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sbc100 sbc100 force-pushed the check_expectations branch 3 times, most recently from e086ce7 to aaa6c5c Compare December 19, 2024 17:43
@kripken
Copy link
Member

kripken commented Dec 19, 2024

Still failing on CI?

@sbc100 sbc100 force-pushed the check_expectations branch from aaa6c5c to b764e20 Compare December 19, 2024 18:50
@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 19, 2024

Looks like it working now

@sbc100 sbc100 requested a review from dschuff December 19, 2024 19:38
dschuff
dschuff reviewed Dec 19, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sbc100 sbc100 force-pushed the check_expectations branch 2 times, most recently from 6d5e83c to 728e55e Compare December 19, 2024 20:22
@sbc100 sbc100 requested a review from dschuff December 19, 2024 20:24
@sbc100 sbc100 force-pushed the check_expectations branch from 728e55e to 5b11b96 Compare December 19, 2024 20:44
@sbc100 sbc100 mentioned this pull request Dec 19, 2024
Closed
@sbc100 sbc100 disabled auto-merge December 19, 2024 21:35
@sbc100 sbc100 merged commit 66c0a02 into emscripten-core:main Dec 19, 2024
20 of 29 checks passed
@sbc100 sbc100 deleted the check_expectations branch December 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

@kripken kripken Awaiting requested review from kripken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @kripken @dschuff